[PATCH] D58722: [MIPS] [microMIPS] Pattern match TruncIntFP

Thu Mar 7 09:10:33 PST 2019

mbrkusanin marked an inline comment as done.
mbrkusanin added inline comments.

================
Comment at: test/CodeGen/Mips/llvm-ir/fptosi.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=mips-linux-gnu   -mcpu=mips32                          -asm-show-inst | FileCheck %s -check-prefixes=ALL,NOT-MM,M32,M32-NOTFP64,M32D
+; RUN: llc < %s -mtriple=mips-linux-gnu   -mcpu=mips32r2                        -asm-show-inst | FileCheck %s -check-prefixes=ALL,NOT-MM,M32,M32-NOTFP64,M32R2
----------------
sdardis wrote:
> Break the line with '\' after the  '|', and only include only one prefix with -check-prefix. Just make sure it's unique in the tests. Drop the excessive whitespace between the arguments.
Can you just clarify what you meant by 'unique'. Unique per RUN: line or unique per generated output with utils/update_llc_test_checks.py?
Right now it is changed to latter (first two RUN:s have same prefix 'M32' since they generate the same output).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58722/new/

https://reviews.llvm.org/D58722