[PATCH] D59036: Memory writes overlap in the pipelined loop

Yan Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 08:57:43 PST 2019


yan_luo updated this revision to Diff 189727.
yan_luo marked an inline comment as done.
yan_luo added a comment.

Only need to check mayStore() on DI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59036/new/

https://reviews.llvm.org/D59036

Files:
  lib/CodeGen/MachinePipeliner.cpp


Index: lib/CodeGen/MachinePipeliner.cpp
===================================================================
--- lib/CodeGen/MachinePipeliner.cpp
+++ lib/CodeGen/MachinePipeliner.cpp
@@ -3131,8 +3131,7 @@
       SI->hasOrderedMemoryRef() || DI->hasOrderedMemoryRef())
     return true;
 
-  if (!(DI->mayStore() && SI->mayLoad()) &&
-      !(DI->mayStore() && SI->mayStore()))
+  if (!DI->mayStore())
     return false;
 
   unsigned DeltaS, DeltaD;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59036.189727.patch
Type: text/x-patch
Size: 449 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190307/03b1edea/attachment.bin>


More information about the llvm-commits mailing list