[PATCH] D56799: [NFC] Factor out + document build requirements

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop added inline comments.
Herald added a subscriber: jdoerfert.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake:44
+    if (CMAKE_CXX_SIMULATE_VERSION VERSION_LESS MSVC_MIN)
+      message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_COMPILER_VERSION}.")
+    endif()
----------------
I think that this should report *SIMULATE* VERSION rather than *COMPILER* version. i.e.
`message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_SIMULATE_VERSION}.")`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56799/new/

https://reviews.llvm.org/D56799