[PATCH] D58451: [DebugInfo] Fix the type of the formated variable

Miloš Stojanović via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 05:22:14 PST 2019


mstojanovic updated this revision to Diff 189697.
mstojanovic added a comment.
Herald added a subscriber: rupprecht.

Set the address output to 64-bit and fixed the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58451/new/

https://reviews.llvm.org/D58451

Files:
  lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
  test/tools/llvm-objdump/eh_frame-coff.test


Index: test/tools/llvm-objdump/eh_frame-coff.test
===================================================================
--- test/tools/llvm-objdump/eh_frame-coff.test
+++ test/tools/llvm-objdump/eh_frame-coff.test
@@ -8,7 +8,7 @@
 # CHECK:   Code alignment factor: 1
 # CHECK:   Data alignment factor: -4
 # CHECK:   Return address column: 8
-# CHECK:   Personality Address: 004025d7
+# CHECK:   Personality Address: 00000000004025d7
 # CHECK:   Augmentation data:     00 D7 25 40 00 00 00
 
 # CHECK:   DW_CFA_def_cfa: reg4 +4
@@ -17,7 +17,7 @@
 # CHECK:   DW_CFA_nop:
 
 # CHECK: 00000020 0000001c 00000024 FDE cie=00000024 pc=00401410...00401488
-# CHECK:   LSDA Address: 00406000
+# CHECK:   LSDA Address: 0000000000406000
 # CHECK:   DW_CFA_advance_loc: 1
 # CHECK:   DW_CFA_def_cfa_offset: +8
 # CHECK:   DW_CFA_offset: reg5 -8
Index: lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
===================================================================
--- lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
+++ lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
@@ -300,7 +300,7 @@
   OS << format("  Data alignment factor: %d\n", (int32_t)DataAlignmentFactor);
   OS << format("  Return address column: %d\n", (int32_t)ReturnAddressRegister);
   if (Personality)
-    OS << format("  Personality Address: %08x\n", *Personality);
+    OS << format("  Personality Address: %016" PRIx64 "\n", *Personality);
   if (!AugmentationData.empty()) {
     OS << "  Augmentation data:    ";
     for (uint8_t Byte : AugmentationData)
@@ -319,7 +319,7 @@
                (uint32_t)InitialLocation,
                (uint32_t)InitialLocation + (uint32_t)AddressRange);
   if (LSDAAddress)
-    OS << format("  LSDA Address: %08x\n", *LSDAAddress);
+    OS << format("  LSDA Address: %016" PRIx64 "\n", *LSDAAddress);
   CFIs.dump(OS, MRI, IsEH);
   OS << "\n";
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58451.189697.patch
Type: text/x-patch
Size: 1824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190307/5dfcc427/attachment.bin>


More information about the llvm-commits mailing list