[PATCH] D59089: [llvm-readobj] Dump DT_USED value as string like GNU readelf does

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-dynamic-tags.test:264-265
         Value: 0x3
+      - Tag:   DT_USED
+        Value: 0x3
       # Show behaviour for unknown values in special and un-marked ranges.
----------------
Could you put this above DT_FILTER, please, since it is before it in the enum range.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1882-1884
+  case DT_USED:
+    printLibrary(OS, "Not needed object", getDynamicString(Value));
+    break;
----------------
Put this before DT_FILTER, similar to my above comment.

To confirm, GNU readelf prints it as "Not needed object"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59089/new/

https://reviews.llvm.org/D59089