[PATCH] D58963: [JumpThreading] Retain debug info when replacing branch instructions

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D58963#1419867 <https://reviews.llvm.org/D58963#1419867>, @dblaikie wrote:

> The code change touches two places, but the test only seems to test one branch instruction - is one of the two code changes untested?


Yes; the second case seemed like it would need an additional, more complicated IR case to test, but the logic for performing the conditional-to-unconditional branch conversion is identical in both cases (could be extracted to a utility function perhaps?) and the semantic meaning is the same as well: "The condition at this state is guaranteed to be true/false, so remove the condition check".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58963/new/

https://reviews.llvm.org/D58963