[PATCH] D59057: AMDHSA: Code object v3 updates

[Tony Tye via Phabricator via llvm-commits]

t-tye requested changes to this revision.
t-tye added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:572
 
-  MCSymbolELF *KernelCodeSymbol = cast<MCSymbolELF>(
-      Context.getOrCreateSymbol(Twine(KernelName)));
-  KernelCodeSymbol->setBinding(ELF::STB_LOCAL);
+  // The visibility of the kernel code symbol must be protected or less.
+  if (KernelCodeSymbol->getVisibility() == ELF::STV_DEFAULT)
----------------
Would it be worth giving the reason? It is to allow static relocations from the kernel descriptor to be used. Since the debugger is using the symtab I wonder if we can use hidden visibility. This symbol does not need to be in the dynsymtab.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59057/new/

https://reviews.llvm.org/D59057