[PATCH] D58801: [Support] Implement is_local_impl with AIX mntctl

Andrew Paprocki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 21:02:50 PST 2019


apaprocki added inline comments.


================
Comment at: lib/Support/Unix/Path.inc:81
+#include <sys/statfs.h>
+typedef uint_t uint;
+#include <sys/vmount.h>
----------------
hubert.reinterpretcast wrote:
> apaprocki wrote:
> > `sys/statfs.h` includes `sys/types.h`, which contains this `typedef`. Was there a reason why it was put here between the two headers?
> Yes, the header is defective. It needs a typedef that is only conditionally defined.
I guess I am not seeing that.. is it OS version dependent?


```
$ cat test.c
#include <sys/statfs.h>
#include <sys/vmount.h>
$ xlc -E -c test.c | grep "typedef.*uint;"
typedef         uint_t          uint;
$
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58801/new/

https://reviews.llvm.org/D58801





More information about the llvm-commits mailing list