[PATCH] D59074: [WebAssembly] Fix build after rL355577

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 21:02:51 PST 2019


sbc100 added a comment.

In D59074#1421059 <https://reviews.llvm.org/D59074#1421059>, @sbc100 wrote:

> In D59074#1421058 <https://reviews.llvm.org/D59074#1421058>, @pcc wrote:
>
> > > Turns own that IsUsedInRegularObject is set for lazy (archive) symbols.
> >
> > Should we fix that, then?
>
>
> It correct according to the comment in ELF/Symbols.h:
>
>   // True if the symbol was used for linking and thus need to be added to the    
>   // output file's symbol table. This is true for all symbols except for         
>   // unreferenced DSO symbols and bitcode symbols that are unreferenced except   
>   // by other bitcode objects.                                                   
>   unsigned IsUsedInRegularObj : 1;    
>   
>
> I guess objects in archives are still regular objects.


Looks like the comment is wrong though.. so fixing: https://reviews.llvm.org/D59075


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59074/new/

https://reviews.llvm.org/D59074





More information about the llvm-commits mailing list