[PATCH] D59005: Fix memory leak in CreateSigAltStack

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 14:11:07 PST 2019


jfb added a comment.

In D59005#1420436 <https://reviews.llvm.org/D59005#1420436>, @fez wrote:

> But now I'm puzzled by this check.
>
>   // If the handlers are already registered, we're done.
>   if (NumRegisteredSignals.load() != 0)
>     return;
>   
>
> This should prevent the call to `CreateSigAltStack` to be reached the second time.
>
> I need to investigate further.


Indeed, that's why I was confused :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59005/new/

https://reviews.llvm.org/D59005





More information about the llvm-commits mailing list