[PATCH] D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 14:02:43 PST 2019


mstorsjo added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.h:123
   // Boolean options
+  bool AddGHashes = false;
   bool DeterministicArchives = true;
----------------
When adding a new option here, it might make sense to add an error to the ELF backend saying that this option is unsupported there. (I think the macho backend still doesn't handle any existing options either, without erroring out, so there's probably no need to add any error there yet.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59025/new/

https://reviews.llvm.org/D59025





More information about the llvm-commits mailing list