[PATCH] D58420: docs/GithubMove.rst: Remove obsolete information

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 13:18:51 PST 2019


smeenai added a comment.

LGTM, for whatever that's worth



================
Comment at: llvm/docs/Proposals/GitHubMove.rst:258
+With the Monorepo, it is undecided whether the existing single-subproject
+mirrors (e.g. http://llvm.org/git/compiler-rt.git) will continue to
+be maintained.
----------------
Super nit: use the newer URL, i.e. https://git.llvm.org/git/compiler-rt.git


================
Comment at: llvm/docs/Proposals/GitHubMove.rst:266
+there have been issues with this bridge working correctly in the past,
+so its not clear if this is something that will be supported going forward.
 
----------------
Super nit: its -> it's


================
Comment at: llvm/docs/Proposals/GitHubMove.rst:276
+   `git push` collisions when upstreaming. Affected contributors may be able to
+   use  the SVN bridge or the single-subproject Git mirrors.  However, it's
+   undecided if these projects will continue to be mantained.
----------------
Super nit: extra space between "use" and "the", and the two spaces after the period don't seem to be consistent with the rest of the document either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58420/new/

https://reviews.llvm.org/D58420





More information about the llvm-commits mailing list