[PATCH] D58857: [HWASan] Save + print registers when tag mismatch occurs in AArch64.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 5 11:28:28 PST 2019
eugenis added inline comments.
================
Comment at: compiler-rt/lib/hwasan/hwasan_linux.cc:390
+ // through the stack saver.
+ if (registers_frame) {
+ stack->trace++;
----------------
check that trace && size > 0 just in case
================
Comment at: compiler-rt/test/hwasan/TestCases/register-dump-read.c:5
+// RUN: %clang_hwasan -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// REQUIRES: android
+
----------------
REQUIRES: aarch64-target-arch
================
Comment at: compiler-rt/test/hwasan/TestCases/register-dump-read.c:21
+
+ // CHECK: ERROR: HWAddressSanitizer:
+ // CHECK: Registers where the failure occurred
----------------
Check that the top frame in the report is as expected, with both settings of fast_unwind_on_fatal.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58857/new/
https://reviews.llvm.org/D58857
More information about the llvm-commits
mailing list