[PATCH] D58952: [llvm] Skip over empty line table entries.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Might be worth a separate/targeted test with some of the interesting edge cases? (like empty range at the end of the sequence, etc)



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:877-878
   }
+  while (RowPos->Address.Address == (RowPos + 1)->Address.Address &&
+         RowPos < LastRow) {
+    ++RowPos;
----------------
I'd probably flip these conditions - even though there is the last row (so RowPos + 1 is valid here), I think it'd read a bit better, maybe?

Also - what happens if the empty range is at the end (eg: LastRowIndex address == second-to-LastRowIndex address)? Maybe that's already handled by the "containsPC" test above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58952/new/

https://reviews.llvm.org/D58952