[PATCH] D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

General question: why not just use llvm-objcopy --add-section to do this?



================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:97
+  if (Data.size() < 4)
+    error(SecName + " too short");
+  if (support::endian::read32le(Data.data()) != COFF::DEBUG_SECTION_MAGIC)
----------------
error() should be replaced with "return createStringError(...)" to let the callers handle errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59025/new/

https://reviews.llvm.org/D59025