[PATCH] D58784: [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 09:15:37 PST 2019


jhenderson added a comment.

In D58784#1419973 <https://reviews.llvm.org/D58784#1419973>, @probinson wrote:

> Sudden thought:  Why are these assertions anyway? Shouldn't they be normal diagnostics? Or does FileCheck always have assertions on?


There are already normal diagnostics preventing the first check being a CHECK-NEXT or CHECK-SAME, so we don't need these assertions at this point, as the diagnostics have already happened. If we remove the assertions as I propose, and decide to let CHECK-SAME be usable on the first line, then those earlier diagnostics will still want to check that CHECK-NEXT is not used there (i.e. remain unchanged for CHECK-NEXT), as they do now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58784/new/

https://reviews.llvm.org/D58784





More information about the llvm-commits mailing list