[PATCH] D59029: [libc++] Do not specify the underlying type of memory_order

[Marshall Clow via Phabricator via llvm-commits]

mclow.lists added a comment.

In D59029#1419972 <https://reviews.llvm.org/D59029#1419972>, @zoecarver wrote:

> Seems good to me. I remember @EricWF saying
>
> > And we should static assert the underlying type of this matches the type we declare in C++17.
>
> and
>
> > I would like to see an explicit underlying type declared here.
>
> though. He might have a point.


I don't see how to do both. - match the C++17 size (which can change), and be explicit.

I liked the `static_assert` that we had before - it found us a bug:  https://bugs.llvm.org/show_bug.cgi?id=40977


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59029/new/

https://reviews.llvm.org/D59029