[PATCH] D58832: [SampleFDO] add suffix elision control for fcn names

[Than McIntosh via Phabricator via llvm-commits]

thanm marked 6 inline comments as done.
thanm added inline comments.


================
Comment at: unittests/ProfileData/SampleProfTest.cpp:228
+
+  void mkModFcn(Module *M, const char *fname, StringRef policy) {
+    FunctionType *fn_type =
----------------
mtrofin wrote:
> For clarity, please give this a more verbose name. If I understand it correctly, this is (for example) ensureSampleProfileSuffixElisionPolicy
> 
> 
OK.  I've renamed to createFunctionWithSampleProfileElisionPolicy


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58832/new/

https://reviews.llvm.org/D58832