[PATCH] D58995: [CGP] Avoid repeatedly building DominatorTree causing long compile-time (NFC)

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 06:27:59 PST 2019


tejohnson added a comment.

In D58995#1419051 <https://reviews.llvm.org/D58995#1419051>, @spatel wrote:

> LGTM
>  Sorry I didn't see this problem, and thanks for fixing it!
>  If you have any perf data that you can share, it would be good to include that here or in the commit message. I'm curious if this change recovers all of the compile-time perf or if walking the icmp users is also expensive (although I'm not sure how to make that any faster).


I don't have data on how much the time was before your patches went in, but I do have some performance data before and after this patch. Will add it in the commit message.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58995/new/

https://reviews.llvm.org/D58995





More information about the llvm-commits mailing list