[PATCH] D59019: [llvm-objcopy] - Remove an excessive zlib::isAvailable() check and dead code.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 06:09:04 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL355503: [llvm-objcopy] - Remove an excessive zlib::isAvailable() check and dead code. (authored by grimar, committed by ).
Herald added a project: LLVM.

Changed prior to commit:
  https://reviews.llvm.org/D59019?vs=189479&id=189492#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59019/new/

https://reviews.llvm.org/D59019

Files:
  llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp


Index: llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp
===================================================================
--- llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp
+++ llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp
@@ -263,12 +263,6 @@
                                      DebugCompressionType CompressionType)
     : SectionBase(Sec), CompressionType(CompressionType),
       DecompressedSize(Sec.OriginalData.size()), DecompressedAlign(Sec.Align) {
-
-  if (!zlib::isAvailable()) {
-    CompressionType = DebugCompressionType::None;
-    return;
-  }
-
   if (Error E = zlib::compress(
           StringRef(reinterpret_cast<const char *>(OriginalData.data()),
                     OriginalData.size()),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59019.189492.patch
Type: text/x-patch
Size: 709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190306/0753c03b/attachment.bin>


More information about the llvm-commits mailing list