[PATCH] D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 04:53:59 PST 2019


dstuttard marked an inline comment as done.
dstuttard added inline comments.


================
Comment at: test/CodeGen/AMDGPU/img-nouse-adjust.ll:14-15
+  %0 = tail call <4 x float> @llvm.amdgcn.image.load.2d.v4f32.i32(i32 15, i32 undef, i32 undef, <8 x i32> undef, i32 0, i32 0) #3
+  call void @llvm.trap()
+  unreachable
+}
----------------
arsenm wrote:
> The trap should be removed and the unreachable replaced with return
The problem doesn't happen if you remove the trap.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58964/new/

https://reviews.llvm.org/D58964





More information about the llvm-commits mailing list