[PATCH] D59017: [llvm-objcopy] - Remove dead code. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 04:42:12 PST 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:184
 template <class ELFT>
 void ELFSectionWriter<ELFT>::visit(const DecompressedSection &Sec) {
   const size_t DataOffset = isDataGnuCompressed(Sec.OriginalData)
----------------
jhenderson wrote:
> I wonder if it's worth making zlib::isAvailable() an assertion in this function?
I think it might be better to have an assert in DecompressedSection's constructor then.
This section is not expected to be created in case of `!zlib::isAvailable()` first of all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59017/new/

https://reviews.llvm.org/D59017





More information about the llvm-commits mailing list