[PATCH] D59019: [llvm-objcopy] - Remove an excessive zlib::isAvailable() check and dead code.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 6 04:33:57 PST 2019
jhenderson added inline comments.
================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:265
: SectionBase(Sec), CompressionType(CompressionType),
DecompressedSize(Sec.OriginalData.size()), DecompressedAlign(Sec.Align) {
if (Error E = zlib::compress(
----------------
Maybe you should have an assertion here so that we don't try to create `CompressedSection` if there is no zlib?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59019/new/
https://reviews.llvm.org/D59019
More information about the llvm-commits
mailing list