[PATCH] D58956: [WebAssembly] Remove tabs in tests (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 17:36:29 PST 2019


aheejin added a comment.

In D58956#1419338 <https://reviews.llvm.org/D58956#1419338>, @sbc100 wrote:

> Isn't this because there are tabs in the output of these tools?  In those cases I think its fine for the tabs to exist in the test expectations (even if they are ignored).  Makes it easier to copy and paste output into expectations.


Yes. And that's the reason I wanted to here people's opinions. The reason I wanted to remove them was we were not consistent on that; most of out `CHECK` lines don't have tabs, only some of them do. So I thought like, if we are not gonna make very CHECK line have tabs, maybe remove them all is consistent. But anyway, as you said, these are generated test lines after all and I don't feel strongly about removing them. I was mostly bored last night. :$


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58956/new/

https://reviews.llvm.org/D58956





More information about the llvm-commits mailing list