[PATCH] D58998: Add declarations of explicit specializations and make primary template deleted

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: lib/Target/Hexagon/RDFGraph.h:941-942
 
+  template <typename T>
+  raw_ostream &operator<< (raw_ostream &OS, const Print<T> &P) = delete;
+
----------------
Should probably move the comment below up here and explain more what this is doing. IE: that this template is explicitly specialized for specific types only, etc.


================
Comment at: lib/Target/Hexagon/RDFGraph.h:944-945
+
+  // Explicit specializations in RDFGraph.cpp. There is an additional explicit
+  // specialization in RDFLiveness.cpp; it is declared in RDFLiveness.h.
+  template<>
----------------
FWIW, I don't think you need to add the forward reference to RDFLiveness.h here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58998/new/

https://reviews.llvm.org/D58998