[PATCH] D58997: Order File Instrumentation: dump the data in compiler-rt (Make it work for Linux/Windows etc)

[Manman Ren via Phabricator via llvm-commits]

manmanren marked 3 inline comments as done.
manmanren added inline comments.


================
Comment at: lib/profile/InstrProfilingPlatformLinux.c:67
 }
+COMPILER_RT_VISIBILITY uint32_t *__llvm_profile_begin_orderfile(void) {
+  return &PROF_ORDERFILE_START;
----------------
I am getting undefined reference to `__start___llvm_orderfile'. Not quite know where we define these symbols for PROF_CNTS etc.


================
Comment at: lib/profile/InstrProfilingPlatformOther.c:88
+COMPILER_RT_VISIBILITY
+uint32_t *__llvm_profile_begin_orderfile(void) { return OrderFileFirst; }
 
----------------
Not sure what I should do for PlatformOther :[


================
Comment at: lib/profile/InstrProfilingPlatformWindows.c:32
 #pragma section(".lprfc$Z", read, write)
+#pragma section(".lorderfile$A", read, write)
 #pragma section(".lprfnd$A", read, write)
----------------
The windows implementation seems to be working at r355357 (http://lab.llvm.org:8011/builders/sanitizer-windows/builds/42814).


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58997/new/

https://reviews.llvm.org/D58997