[PATCH] D58967: [DAGCombiner] Add SADDO/SSUBO combine support

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 14:16:30 PST 2019


RKSimon added a comment.

In D58967#1418877 <https://reviews.llvm.org/D58967#1418877>, @spatel wrote:

> Ah, I'm getting the order of the patches mixed up. Are we missing tests for when the flag result is unused, or is that already covered elsewhere?


On scalars we do have some tests that cover this. For vectors I haven't thought of a good way to test this yet as expansion strips it away if its not used.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58967/new/

https://reviews.llvm.org/D58967





More information about the llvm-commits mailing list