[PATCH] D58993: AMDGPU: Handle "uniform-work-group-size" attribute (fix for RADV)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM except for all the trailing whitespace



================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:239-242
+    Callee.addFnAttr("uniform-work-group-size", "false");
+    if (!Caller.hasFnAttribute("uniform-work-group-size")) 
+      Caller.addFnAttr("uniform-work-group-size", "false");
+     
----------------
There's some trailing whitespace in the patch, fix before committing


================
Comment at: test/CodeGen/AMDGPU/uniform-work-group-test.ll:1
+; RUN: opt -S -mtriple=amdgcn-amd- -amdgpu-annotate-kernel-features %s | FileCheck %s 
+
----------------
Missing amdhsa part of triple


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58993/new/

https://reviews.llvm.org/D58993