[PATCH] D58988: [Sanitizer] Protect UnwindFast with IsValidFrame on MIPS

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_stack.cc:68
   if (request_fast) {
-    if (t) {
+    if (t && (!SANITIZER_MIPS ||
+              IsValidFrame(bp, t->stack_top(), t->stack_bottom()))) {
----------------
Previously It protected both.
However original commit for this check mentions that MIPS use only Slow and it lacks IsValid check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58988/new/

https://reviews.llvm.org/D58988