[PATCH] D58967: [DAGCombiner] Add SADDO/SSUBO combine support

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 11:18:10 PST 2019


RKSimon added a comment.

In D58967#1418826 <https://reviews.llvm.org/D58967#1418826>, @spatel wrote:

> I think we'd do better by making a helper for the common code rather than duplicating. These things tend to diverge because someone will come along later and add a fold for 1 opcode but forget to add the corresponding fold for its sibling. This might've already happened because we allow vectors for the signed ops, but not the unsigned ops...or that's the planned follow-up?


I'm happy to fold this into a generalized version of visitUADDO/visitUSUBO once D58965 <https://reviews.llvm.org/D58965> has landed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58967/new/

https://reviews.llvm.org/D58967





More information about the llvm-commits mailing list