[PATCH] D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE

Tue Mar 5 11:01:14 PST 2019

dblaikie added a comment.

In D58712#1417984 <https://reviews.llvm.org/D58712#1417984>, @sarveshtamba wrote:

> Hi @dblaikie,
>
> While building Apple Swift 5.0 toolchain on PowerPC64LE, we hit up on the following error(details in first comment) while going through the step "--- Installing swiftpm ---" i.e. installation of the swift package manager:-
>
>   		swift: /home/sar/swift-source/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:12111: llvm::SDValue combineBVOfConsecutiveLoads(llvm::SDNode *, llvm::SelectionDAG &): Assertion `!(InputsAreConsecutiveLoads && InputsAreReverseConsecutive) && "The loads cannot be both consecutive and reverse consecutive."' failed.
>
>
> The change fixes this issue by correctly calculating the PreviousInput and the NextInput.
>  Let me know if this is not the correct approach.

Are you sure you have the correct change here - this code review only shows "++i" changing to "i++" in a context where the value of cthe expression is discarded. In a valid C++ program there's no way I know of that this change could effect the behavior of the program.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58712/new/

https://reviews.llvm.org/D58712