[PATCH] D58966: [libc++] Fix <atomic> failures on GCC
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 5 08:05:23 PST 2019
ldionne marked an inline comment as done.
ldionne added inline comments.
================
Comment at: libcxx/trunk/include/atomic:1458
_LIBCPP_CHECK_STORE_MEMORY_ORDER(__m)
- {__cxx_atomic_store(&__a_, __d, static_cast<__memory_order_underlying_t>(__m));}
+ {__cxx_atomic_store(&__a_, __d, __m);}
_LIBCPP_INLINE_VISIBILITY
----------------
zoecarver wrote:
> Some reason these arent `static_cast`ed?
Yes -- all the `__cxx_atomic_foo` functions take a `memory_order` argument, not an `int`.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58966/new/
https://reviews.llvm.org/D58966
More information about the llvm-commits
mailing list