[PATCH] D58881: [Transform] Improve fold of sadd.with.overflow

Dan Robertson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 05:50:04 PST 2019


dlrobertson added a comment.

In D58881#1418025 <https://reviews.llvm.org/D58881#1418025>, @lebedev.ri wrote:

> Yes, absolutely.
>
> 1. That makes the diff readable. The changes will be visible, not just the test addition.
> 2. That helps with test coverage. You want those tests regardless of whether the change itself will land or be reverted.


Yeah that makes sense. Thanks for the explanation. I'll try to do this for future changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58881/new/

https://reviews.llvm.org/D58881





More information about the llvm-commits mailing list