[PATCH] D58939: [Subtarget] Merge ProcSched and ProcDesc arrays in MCSubtargetInfo into a single array.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 5 04:34:37 PST 2019
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
LGTM. Very nice refactoring.
================
Comment at: utils/TableGen/SubtargetEmitter.cpp:1422
- OS << "\n#undef DBGFIELD";
+ OS << "\n#undef DBGFIELD\n";
}
----------------
Macro function DBGFIELD(x) is only used from code generated by method `EmitSchedClassTables`. We can probably `undef DBGFIELD` after the call to EmitSchedClassTables and before the call to `EmitProcessorModels`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58939/new/
https://reviews.llvm.org/D58939
More information about the llvm-commits
mailing list