[PATCH] D58908: [llvm-objcopy] - SImplify `isCompressable` and fix the issue relative.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 03:48:40 PST 2019


grimar added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:227-230
+  if ((Section.Flags & ELF::SHF_COMPRESSED) ||
+      StringRef(Section.Name).startswith(".zdebug"))
+    return false;
+  return StringRef(Section.Name).startswith(".debug");
----------------
jhenderson wrote:
> Now that you've changed this further, this can be even simpler, I think:
> 
> ```
> return !(Section.Flags & ELF::SHF_COMPRESSED) &&
>            StringRef(Section.Name).startswith(".debug");
> ```
Yep. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58908/new/

https://reviews.llvm.org/D58908





More information about the llvm-commits mailing list