[PATCH] D58958: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: hans, rnk.
Herald added subscribers: Sanitizers, jdoerfert, kubamracek.
Herald added projects: LLVM, Sanitizers.

The TraceLoggingProvider.h header does work with clang-cl in general these days (contrary to when PR32021 was filed originally), but when compiled in 32 bit x86 mode, with the -Z7 flag, compilation fails with the following error:

fatal error: error in backend: assembler label '' can not be undefined


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D58958

Files:
  lib/sanitizer_common/sanitizer_common.h


Index: lib/sanitizer_common/sanitizer_common.h
===================================================================
--- lib/sanitizer_common/sanitizer_common.h
+++ lib/sanitizer_common/sanitizer_common.h
@@ -804,7 +804,7 @@
 
 void WriteToSyslog(const char *buffer);
 
-#if defined(SANITIZER_WINDOWS) && defined(_MSC_VER)
+#if defined(SANITIZER_WINDOWS) && defined(_MSC_VER) && !defined(__clang__)
 #define SANITIZER_WIN_TRACE 1
 #else
 #define SANITIZER_WIN_TRACE 0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58958.189294.patch
Type: text/x-patch
Size: 466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190305/f6ec884b/attachment.bin>