[PATCH] D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 18:51:35 PST 2019


Higuoxing added a comment.

In D58873#1417862 <https://reviews.llvm.org/D58873#1417862>, @efriedma wrote:

> Oh, I see, you changed the instruction bytes for the test.
>
> Are you planning to fix the decoding for "dbg" instructions?  If not, is there a bug filed?


I think there's no bug here, what we need is an `undefined encoding space for hint instruction` test. So, `[0xfe 0xf0 0x20 0xf3]` is an invalid instruction which has an invalid `cond` field. According to the manual, there's only one invalid instruction in `dbg hint instruction`, which is this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58873/new/

https://reviews.llvm.org/D58873





More information about the llvm-commits mailing list