[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.

> I agree with you that people should always use the command-line option to tell the linker that the feature is desired/required. If there is a common command line between ld, bfd and to a lesser extend gold, then the linker driver should set it if the compiler flag has been used.

Thank you, peter, the table is very clear!
Just one point I want to say: We do not need check the compiler flags, Because if the CET flag exist in input files, it has directly mean the compiler flag been used.

My appoint is similar to yours.
And another my concern is the transition period of using CET:
If CET can only be enabled by manual behavior, I can make sure that no body will open CET option in this period, because they are very easy to get link errors when they are trying to link files. People will directly remove the CET options in their projects (if contain CET at first).

In fact, CET works in units of program processes，it can and should be enabled in OS or other platforms piece by piece, otherwise it will be very hard to pass the transition period time.

This week Lu.H.J (CET designer and Implementer in GNU) will come, I will discuss all your ideas with him.
Thank you! all here friends


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102