[PATCH] D58881: [Transform] Improve fold of sadd.with.overflow

Dan Robertson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 16:39:26 PST 2019


dlrobertson added a comment.

> I've committed your tests with the current output in rL355328 <https://reviews.llvm.org/rL355328>. Can you please rebase this revision over the committed tests, so that only the changes made by the new transform remain?

Is this the preferred way to add tests? E.g. for the future changes I make for `uadd.with.overflow`, should I add the tests in a diff and then follow the diff up with another that also contains code changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58881/new/

https://reviews.llvm.org/D58881





More information about the llvm-commits mailing list