[PATCH] D58899: [CodeGen] Prepare for introduction of v3 and v5 MVTs

Mon Mar 4 15:24:57 PST 2019

tpr marked 4 inline comments as done.
tpr added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:343
   EVT OrigTy = TLI->getValueType(DL, Ty);
-  if (!OrigTy.isSimple()) {
+  if (!OrigTy.isSimple() || (OrigTy.isVector() && !OrigTy.isPow2VectorType())) {
     return BaseT::getArithmeticInstrCost(Opcode, Ty, Opd1Info, Opd2Info,
----------------
arsenm wrote:
> This could use a test in test/Analysis/CostModel/AMDGPU
I have separated out the amdgpu changes into another commit, but:

In adding v5 cost model tests, I found that (a) this change here is unnecessary, and (b) I had a bug in one of my later changes (the one that makes v5 legal on amdgpu) that made the test fail. So I have added the tests.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58899/new/

https://reviews.llvm.org/D58899