[PATCH] D58250: [AIX][CMake] Changes for building on AIX with XL and GCC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Config/abi-breaking.h.cmake:37
 #elif defined(__cplusplus)
+#if !(defined(_AIX) && defined(__GNU__))
+#define LLVM_HIDDEN_VISIBILITY __attribute__ ((visibility("hidden")))
----------------
`__GNU__` is not the macro we want to check here (it checks for GNU Hurd, i.e., the OS). The intention is to check for GCC. I am not sure if there is a better way to check for "real" GCC as opposed to the GCC-compatible compilers other than to filter for each of the known compatible compilers that do not suffer from the same limitation as GCC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58250/new/

https://reviews.llvm.org/D58250