[PATCH] D58915: [AArch64] Refactor floating point materialization. NFC

Mon Mar 4 12:40:35 PST 2019

efriedma added inline comments.

================
Comment at: lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:122

-  // FIXME: Prefer MOVZ/MOVN over ORR because of the rules for the "mov"
-  // alias.
+  SmallVector<MachineInstrBuilder, 5> MIBS;
+  for (auto &I : Insn) {
----------------
5?

================
Comment at: lib/Target/AArch64/MCTargetDesc/CMakeLists.txt:5
   AArch64ELFStreamer.cpp
+  AArch64ExpandImm.cpp
   AArch64MCAsmInfo.cpp
----------------
Probably shouldn't be in MCTargetDesc; just lib/Target/AArch64/ is fine.  MCTargetDesc generally only contains code used by the assembler, and there isn't any AArch64 directive that would require the assembler to expand an immediate.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58915/new/

https://reviews.llvm.org/D58915