[PATCH] D58887: PHI nodes are not `FPMathOperator` s
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 4 11:39:58 PST 2019
sanjoy updated this revision to Diff 189178.
sanjoy added a comment.
Add unit test
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58887/new/
https://reviews.llvm.org/D58887
Files:
include/llvm/IR/Operator.h
unittests/IR/InstructionsTest.cpp
Index: unittests/IR/InstructionsTest.cpp
===================================================================
--- unittests/IR/InstructionsTest.cpp
+++ unittests/IR/InstructionsTest.cpp
@@ -993,5 +993,14 @@
EXPECT_EQ(nullptr, Term->getNextNonDebugInstruction());
}
+TEST(InstructionsTest, PhiIsNotFPMathOperator) {
+ LLVMContext Context;
+ IRBuilder<> Builder(Context);
+ MDBuilder MDHelper(Context);
+ Instruction *I = Builder.CreatePHI(Builder.getDoubleTy(), 0);
+ EXPECT_FALSE(isa<FPMathOperator>(I));
+ I->deleteValue();
+}
+
} // end anonymous namespace
} // end namespace llvm
Index: include/llvm/IR/Operator.h
===================================================================
--- include/llvm/IR/Operator.h
+++ include/llvm/IR/Operator.h
@@ -379,6 +379,7 @@
case Instruction::ExtractElement:
case Instruction::ShuffleVector:
case Instruction::InsertElement:
+ case Instruction::PHI:
return false;
default:
return V->getType()->isFPOrFPVectorTy();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58887.189178.patch
Type: text/x-patch
Size: 1006 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190304/b05d7ef7/attachment.bin>
More information about the llvm-commits
mailing list