[PATCH] D58911: DAG: Don't break value dependencies when sorting loads by offset

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:270
+    // dependencies between some of the loads. Sort them when asking the target.
+    int64_t LowOffset = std::min(BaseOff, Offset);
+    int64_t HighOffset = std::max(BaseOff, Offset);
----------------
rampitec wrote:
> Isn't that easier and cleaner to compute new BaseOff once yet while sorting?
This is dependent on each offset so
I don’t understand what you mean . The alternative is to delete the assert in the SI implementation, which isn’t really necessary


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58911/new/

https://reviews.llvm.org/D58911