[PATCH] D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 07:40:12 PST 2019


dblaikie added a comment.

The patch title doesn't seem related (or I don't understand how it's related) to the patch, and the patch description doesn't seem to detail how it relates to the code change.

And the code change doesn't seem to me like it could have any effect on semantics/fix any bug.

And the change has no test case.

Could you provide a test case and a more specific description of the issue and why this change is meaningful/fixes the issue?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58712/new/

https://reviews.llvm.org/D58712





More information about the llvm-commits mailing list