[PATCH] D58872: [InstCombine] Start canonicalizing to uadd.sat and usub.sat

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Hello. This one looks OK from the tests I just ran. A few things moved, but only by a small amount, and usually in the right direction.

I think the "with.overflow" intrinsics were causing more problems for us. These saturations, at least in the tests I've ran, seem to be handled OK.



================
Comment at: test/Transforms/InstCombine/unsigned_saturated_sub.ll:131
 
 ; ((b > a) ? 0 : b - a) -> - ((a > b) ? a : b) - b)
 
----------------
Do these comments need updating?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58872/new/

https://reviews.llvm.org/D58872