[PATCH] D58520: [Subtarget] Remove static global constructor call from the tablegened subtarget feature tables

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/trunk/utils/TableGen/SubtargetEmitter.cpp:185
+
+  OS << "{ { ";
+  for (unsigned i = 0; i != Mask.size(); ++i) {
----------------
@craig.topper, I see lots of warning when compiling using clang 3.6 after this patch:
```
lib/Target/AArch64/AArch64GenSubtargetInfo.inc:167:63: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
  { "a35", "Cortex-A35 ARM processors", AArch64::ProcA35, { { 0x20800080800800ULL, 0x0ULL, 0x0ULL, } } },
                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                               {                                  }
```

Adding one more level of braces "{ { { 0x20800080800800ULL, 0x0ULL, 0x0ULL, } } }" seems to work, but would that mean that we no longer run the new constexpr ctor?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58520/new/

https://reviews.llvm.org/D58520