[PATCH] D55538: [InterleavedAccessAnalysis] Fix integer overflow in insertMember.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Sorry for the long delay....

In D55538#1336581 <https://reviews.llvm.org/D55538#1336581>, @efriedma wrote:

> I don't understand the implications of returning false here...


It indicates to the caller that the instruction wasn't added to the interleave group. It's checked in analyzeInterleaving (in VectorUtils.cpp), to see if we should add the group to  InterleaveGroupMap for the instruction. Returning false and not inserting the member should always be safe.

> I'd like to see a general plan for eventually excising the use of "int" from all the interleaving code before we start making changes here, so it's clear we're heading in the right direction.

I've put up D58889 <https://reviews.llvm.org/D58889>, which switches to fixed size integer types. Is that along the lines you were thinking?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55538/new/

https://reviews.llvm.org/D55538