[PATCH] D58486: [WebAssembly] Delete ThrowUnwindDest map from WasmEHFuncInfo

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 3 13:39:20 PST 2019


aheejin requested review of this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

In D58486#1407525 <https://reviews.llvm.org/D58486#1407525>, @dschuff wrote:

> Makes sense.
>  Is `EHPadUnwindMap` analogous to any of the similarly-named data structures for WinEH? If so, that would seem to make it even less likely to accidentally break, since any change that breaks it would also break WinEH.


Not exactly. (I tried but) I don't understand their structure 100% but it looks like they assign state numbers to layers of BB groups created by EH pads. So for example an EH pad has a state number 1, within BBs that's dominated by that EH pad, the next level EH pads are assigned number 2, and so on. But anyway, I think as long as this nested structure of EH pads are preserved we are ok.

(And I thought I had to change something but I didn't, so I'm changing the status back)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58486/new/

https://reviews.llvm.org/D58486





More information about the llvm-commits mailing list