[PATCH] D58884: [DAGCombiner][X86][SystemZ][AArch64] Combine some cases of (bitcast (build_vector constants)) between legalize types and legalize dag.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added subscribers: jonpa, uweigand.
spatel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10210-10211
+  // Only do this before legalize types, unless both types are integer and the
+  // scalar type is legal. Even if we knew we wouldn't create an illegal scalar
+  // type we can only do this before legalize ops, since the target maybe
   // depending on the bitcast.
----------------
Remove the 'Even if' line of the comment now? Add a TODO for FP?


================
Comment at: test/CodeGen/SystemZ/vec-extract-01.ll:9
+; CHECK: llihf [[REG:%r[0-5]]], 1000000
+; CHECK: oilf [[REG]], 99999
 ; CHECK: stg [[REG]], 0(%r2)
----------------
cc @uweigand @jonpa to confirm this diff is ok.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58884/new/

https://reviews.llvm.org/D58884